Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1146973002: Rename remaining runtime-error methods from errorX to visitX. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename remaining runtime-error methods from errorX to visitX. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/393272d0df23bf68cd8ca9f505bfb1c36515050c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -367 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 14 chunks +19 lines, -85 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 23 chunks +23 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 34 chunks +385 lines, -230 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 14 chunks +23 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-20 13:50:35 UTC) #2
karlklose
LGTM.
5 years, 7 months ago (2015-05-20 14:13:30 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-21 07:04:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
393272d0df23bf68cd8ca9f505bfb1c36515050c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698