Issue 11468039: Make pipeInputToInput yet more resilient to stream closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11468039: Make pipeInputToInput yet more resilient to stream closure. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make pipeInputToInput yet more resilient to stream closure. Committed: https://code.google.com/p/dart/source/detail?r=15882

Patch Set 2 : Previous fix didn't work #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	utils/pub/io.dart	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/11468039/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11468039/diff/1/utils/pub/io.dart#newcode628 utils/pub/io.dart:628: // get sink.closed to be set correctly. Add ...

8 years ago (2012-12-08 03:51:05 UTC) #2

nweiz

On 2012/12/08 03:51:05, Bob Nystrom wrote: > LGTM. > > https://codereview.chromium.org/11468039/diff/1/utils/pub/io.dart > File utils/pub/io.dart (right): ...

8 years ago (2012-12-08 03:58:35 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 11468039: Make pipeInputToInput yet more resilient to stream closure. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Previous fix didn't work #

Messages