Issue 11464032: Add some relatively innocuous logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11464032: Add some relatively innocuous logging. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add some relatively innocuous logging. Committed: https://code.google.com/p/dart/source/detail?r=15876

Created: 8 years ago

	Unified diffs	Side-by-side diffs	Stats (+324 lines, -45 lines)
M	utils/pub/command_help.dart	View	2 chunks	+3 lines, -2 lines	0 comments
M	utils/pub/command_install.dart	View	2 chunks	+2 lines, -1 line	0 comments
M	utils/pub/command_update.dart	View	2 chunks	+2 lines, -1 line	0 comments
M	utils/pub/git.dart	View	2 chunks	+2 lines, -0 lines	0 comments
M	utils/pub/hosted_source.dart	View	2 chunks	+2 lines, -1 line	0 comments
A	utils/pub/log.dart	View	1 chunk	+217 lines, -0 lines	0 comments
M	utils/pub/pub.dart	View	10 chunks	+65 lines, -28 lines	0 comments
M	utils/pub/system_cache.dart	View	2 chunks	+2 lines, -0 lines	0 comments
M	utils/pub/validator.dart	View	2 chunks	+7 lines, -6 lines	0 comments
M	utils/pub/version_solver.dart	View	6 chunks	+10 lines, -1 line	0 comments
M	utils/tests/pub/pub_test.dart	View	1 chunk	+10 lines, -3 lines	0 comments
M	utils/tests/pub/test_pub.dart	View	1 chunk	+2 lines, -2 lines	0 comments

Total messages: 2 (0 generated)

Bob Nystrom

Part 3. This actually does some logging but not in any of the tricky code.

8 years ago (2012-12-07 21:45:08 UTC) #1

lgtm