Issue 11464026: Diagnose illegal lvalues better.

Issue 11464026: Diagnose illegal lvalues better. (Closed)

Created:
8 years ago by ahe

Modified:
8 years ago

Reviewers:
Johnni Winther, karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Diagnose illegal lvalues better. Also, make sure that internal parser errors are reported as crashes. BUG=http://dartbug.com/6460 Committed: https://code.google.com/p/dart/source/detail?r=15901

Patch Set 2 : Fix additional issues found during testing. #

Total comments: 2

Patch Set 3 : Remove dead code #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -8 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1 2	5 chunks	+25 lines, -8 lines	0 comments	Download
M	dart/tests/language/syntax_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/11464026/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/11464026/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode165 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:165: pleaseReportCrash(); You're just too nice Peter :-)

8 years ago (2012-12-09 21:06:56 UTC) #2

ahe

On 2012/12/10 08:10:47, ahe wrote: > Thank you, Nicolas. > > PTAL at patch set ...

8 years ago (2012-12-10 08:11:11 UTC) #4

karlklose

https://codereview.chromium.org/11464026/diff/9001/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart File dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart (right): https://codereview.chromium.org/11464026/diff/9001/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart#newcode1346 dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1346: argumentSend = new Send(null, argument); Isn't this dead code?

8 years ago (2012-12-10 08:51:01 UTC) #6

ahe

8 years ago (2012-12-10 12:52:35 UTC) #7

Thank you, Karl and Nicolas!

https://codereview.chromium.org/11464026/diff/9001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
(right):

https://codereview.chromium.org/11464026/diff/9001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1346:
argumentSend = new Send(null, argument);
On 2012/12/10 08:51:01, karlklose wrote:
> Isn't this dead code?

Yes. Removed.

Expand Messages | Collapse Messages