Issue 1146283006: Close files used in some tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146283006: Close files used in some tests (Closed)

Created:
5 years, 7 months ago by Søren Gjesse

Modified:
5 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Close files used in some tests On windows forgetting to close files causes the deletion of the temporary test directory to fail. R=whesse@google.com BUG=http://dartbug.com/23521 Committed: https://github.com/dart-lang/sdk/commit/e382e87e65a1cb77136e7dbd4503fc5593d4a297

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tests/standalone/io/file_test.dart	View		4 chunks	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

5 years, 7 months ago (2015-05-27 13:31:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e382e87e65a1cb77136e7dbd4503fc5593d4a297 (presubmit successful).