Fix typo in ListMixin.insertAll.

Fix typo in ListMixin.insertAll.

Also add test for input iterable being linked to receiver list.

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/6f2dd2552c2e013a5c074c5a741762bb6d541e0a

[Lasse Reichstein Nielsen, 2015-06-01 11:06:33]

lrn@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2015-06-01 11:37:57]

lgtm

https://codereview.chromium.org/1146163004/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/1146163004/diff/1/sdk/lib/collection/list.dar...
sdk/lib/collection/list.dart:479: if (iterable is! EfficientLength ||
identical(iterable, this)) {
Are these cased covered by tests? I guess that we only have tests where
"identical" is hit which also has EfficientLength.

[Lasse Reichstein Nielsen, 2015-06-01 13:13:10]

https://codereview.chromium.org/1146163004/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/1146163004/diff/1/sdk/lib/collection/list.dar...
sdk/lib/collection/list.dart:479: if (iterable is! EfficientLength ||
identical(iterable, this)) {
On 2015/06/01 11:37:57, Søren Gjesse wrote:
> Are these cased covered by tests?

Probably not. It's hard to test because it only affects performance, not
behavior. There should still be coverage for the code, but it wouldn't have
caught the inverted is-test here.

> I guess that we only have tests where
> "identical" is hit which also has EfficientLength.

Since this object is a List which always has EfficientLength, identical implies
"is EfficientLength".

[Lasse Reichstein Nielsen, 2015-06-02 10:04:29]

Committed patchset #1 (id:1) manually as
6f2dd2552c2e013a5c074c5a741762bb6d541e0a (presubmit successful).