Issue 114613003: double * int returns a double can be simplified to an int if both operands are constants. Therefore…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114613003: double * int returns a double can be simplified to an int if both operands are constants. Therefore… (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

double * int returns a double can be simplified to an int if both operands are constants. Therefore the optimization in the instruction simplified to narrow the type should not be done for numbers, or we would end up using an empty type. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31266

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+13 lines, -5 lines	0 comments	Download
A	tests/language/issue15702_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r31266 (presubmit successful).

Expand Messages | Collapse Messages