Chromium Code Reviews

Issue 1145483003: Use http_multi_server for serving on localhost. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use http_multi_server for serving on localhost. This helps avoid issues where "localhost" means different things on different platforms. Closes #100 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/0ae5ab05a0768af1c0cdc5ed395e8c660693819f

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -4 lines)
M lib/src/runner/browser/server.dart View 3 chunks +4 lines, -4 lines 0 comments
M pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 7 months ago (2015-05-18 22:03:20 UTC) #1
kevmoo
lgtm w/ -dev
5 years, 7 months ago (2015-05-18 23:34:22 UTC) #2
nweiz
5 years, 7 months ago (2015-05-19 00:49:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ae5ab05a0768af1c0cdc5ed395e8c660693819f (presubmit successful).

Powered by Google App Engine