Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145403002: Upgrade to test 0.12.0. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/args@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update imports. #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pubspec.yaml View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/args_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/command_parse_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/command_runner_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/command_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/parse_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/trailing_options_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/usage_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 7 months ago (2015-05-21 01:33:20 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1145403002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1145403002/diff/20001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.13.0 Bump this and update the CHANGELOG.
5 years, 7 months ago (2015-05-21 16:30:42 UTC) #2
nweiz
Code review changes
5 years, 7 months ago (2015-05-21 19:09:31 UTC) #3
nweiz
https://codereview.chromium.org/1145403002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1145403002/diff/20001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.13.0 On 2015/05/21 16:30:42, Bob Nystrom wrote: > ...
5 years, 7 months ago (2015-05-21 19:12:12 UTC) #4
Bob Nystrom
lgtm
5 years, 7 months ago (2015-05-21 20:25:40 UTC) #5
nweiz
5 years, 7 months ago (2015-05-21 20:29:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d18f00329e05db68dc79d01b05890a4f99a97e12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698