Issue 1145373006: Remove a conflicting definition of runningAsTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145373006: Remove a conflicting definition of runningAsTest. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub_test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove a conflicting definition of runningAsTest. It turns out this variable already existed, with slightly different semantics. Everything has now been updated, so "runningAsTest" means running in a test file and "runningFromTest" means running in pub called by a test file. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/7a09eba567d2098691830ea24fa61096bff96c74

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	lib/src/io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/utils.dart	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	test/ascii_tree_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 7 months ago (2015-05-28 00:01:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7a09eba567d2098691830ea24fa61096bff96c74 (presubmit successful).