Issue 11453027: Fixed a lot of dartanalyzer static analysis issues with the html lib.

Issue 11453027: Fixed a lot of dartanalyzer static analysis issues with the html lib. (Closed)

Created:
8 years ago by Emily Fortuna

Modified:
3 years, 3 months ago

Reviewers:
Anton Muhin, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed a lot of dartanalyzer static analysis issues with the html lib. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15798

Patch Set 2 : addressed comments #

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -26 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	7 chunks	+25 lines, -8 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1	7 chunks	+25 lines, -8 lines	0 comments	Download
M	sdk/lib/html/src/CrossFrameTypes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/src/Isolates.dart	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	sdk/lib/html/src/KeyboardEventController.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/src/dart2js_KeyEvent.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	sdk/lib/html/src/dartium_KeyEvent.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/html/keyboard_event_test.dart	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Just two last stubborn errors from dartanalyzer after this CL.

8 years ago (2012-12-06 02:33:18 UTC) #1

Anton Muhin

DBC https://codereview.chromium.org/11453027/diff/1/sdk/lib/html/src/Isolates.dart File sdk/lib/html/src/Isolates.dart (right): https://codereview.chromium.org/11453027/diff/1/sdk/lib/html/src/Isolates.dart#newcode34 sdk/lib/html/src/Isolates.dart:34: return [ 'sendport', 'dart', that probably fits a ...

8 years ago (2012-12-06 14:50:40 UTC) #2

blois

lgtm https://codereview.chromium.org/11453027/diff/1/sdk/lib/html/src/dart2js_KeyEvent.dart File sdk/lib/html/src/dart2js_KeyEvent.dart (right): https://codereview.chromium.org/11453027/diff/1/sdk/lib/html/src/dart2js_KeyEvent.dart#newcode112 sdk/lib/html/src/dart2js_KeyEvent.dart:112: throw new UnsupportedError("keyIdentifier is deprecated"); Deprecated is probably ...

8 years ago (2012-12-06 18:23:12 UTC) #3

Emily Fortuna

8 years ago (2012-12-06 18:27:49 UTC) #4

https://codereview.chromium.org/11453027/diff/1/tests/html/keyboard_event_tes...
File tests/html/keyboard_event_test.dart (right):

https://codereview.chromium.org/11453027/diff/1/tests/html/keyboard_event_tes...
tests/html/keyboard_event_test.dart:26:
document.query('body').on.keyDown.add((e) => print('regular listener'), false);
On 2012/12/06 18:23:12, blois wrote:
> document.body?

It's "hidden" as $dom_body these days, so I thought I wasn't supposed to use it
anymore?

Expand Messages | Collapse Messages