Issue 11453009: Report a compile-time error when a setter has not exactly one formal parameter.

Issue 11453009: Report a compile-time error when a setter has not exactly one formal parameter. (Closed)

Created:
8 years ago by karlklose

Modified:
8 years ago

Reviewers:
erikcorry, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report a compile-time error when a setter has not exactly one formal parameter. BUG=dartbug.com/4870 Committed: https://code.google.com/p/dart/source/detail?r=15774

Patch Set 2 : Address comments. #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	1 chunk	+9 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11453009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11453009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3043 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3043: compiler.reportMessage(compiler.spanFromElement(element), I think a better location would be: ...

8 years ago (2012-12-05 20:17:06 UTC) #2

karlklose

Thanks, Peters! https://codereview.chromium.org/11453009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11453009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3043 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3043: compiler.reportMessage(compiler.spanFromElement(element), On 2012/12/05 20:17:06, ahe wrote: > ...

8 years ago (2012-12-06 09:13:32 UTC) #3

ngeoffray

8 years ago (2012-12-09 20:44:00 UTC) #4

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/11453009/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/11453009/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3040: DartType
returnType = compiler.resolveReturnType(element, returnNode);
This can move line 3050.

https://codereview.chromium.org/11453009/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3043: // If
there are no formal parameters, we already reported an error above.
Somehow this looks a bit brittle. Could you instead switch on the element kind
and report errors for each?

Expand Messages | Collapse Messages