Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145063003: Do not emit debug check in optimized IC stubs (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : c #

Patch Set 3 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M runtime/vm/stub_code.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 5 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 6 months ago (2015-05-27 23:34:00 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1145063003/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/1145063003/diff/1/runtime/vm/stub_code_mips.cc#newcode1746 runtime/vm/stub_code_mips.cc:1746: kIgnoreRanges, true); Here and in the other places: ...
5 years, 6 months ago (2015-05-28 08:36:17 UTC) #3
srdjan
https://codereview.chromium.org/1145063003/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/1145063003/diff/1/runtime/vm/stub_code_mips.cc#newcode1746 runtime/vm/stub_code_mips.cc:1746: kIgnoreRanges, true); On 2015/05/28 08:36:17, Florian Schneider wrote: > ...
5 years, 6 months ago (2015-05-28 16:24:10 UTC) #4
srdjan
5 years, 6 months ago (2015-05-28 16:32:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e68d22ce1e22bf14fb228b2598b5381fa94e9d55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698