Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1144923012: Fix dartdoc for InstanceMirror.delegate and ClosureMirror. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix dartdoc for InstanceMirror.delegate and ClosureMirror. Avoid misleading use of the term 'evaluation'. BUG=http://dartbug.com/15889 BUG=http://dartbug.com/20139 BUG=http://dartbug.com/21992 R=gbracha@google.com Committed: https://github.com/dart-lang/sdk/commit/cef08e5674388cbffc965eceb94152d68d709616

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M sdk/lib/mirrors/mirrors.dart View 1 2 3 chunks +14 lines, -7 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
5 years, 6 months ago (2015-06-04 23:13:25 UTC) #2
rmacnak
5 years, 6 months ago (2015-06-09 00:22:21 UTC) #4
gbracha
If this has to be, it has to be. see the comments, but I can ...
5 years, 6 months ago (2015-06-09 00:27:41 UTC) #5
rmacnak
https://chromiumcodereview.appspot.com/1144923012/diff/40001/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://chromiumcodereview.appspot.com/1144923012/diff/40001/sdk/lib/mirrors/mirrors.dart#newcode525 sdk/lib/mirrors/mirrors.dart:525: * introspect its function. On 2015/06/09 00:27:41, gbracha wrote: ...
5 years, 6 months ago (2015-06-09 00:40:10 UTC) #6
rmacnak
5 years, 6 months ago (2015-06-09 00:41:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cef08e5674388cbffc965eceb94152d68d709616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698