Issue 1144893002: Issue 23481. Fix for creating a new class referenced from an inner local function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1144893002: Issue 23481. Fix for creating a new class referenced from an inner local function. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Issue 23481. Fix for creating a new class referenced from an inner local function. R=paulberry@google.com, brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=23481 Committed: https://github.com/dart-lang/sdk/commit/d5774c5402097708246d25ca18c1182e9af8f476

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as d5774c5402097708246d25ca18c1182e9af8f476 (presubmit successful).

5 years, 7 months ago (2015-05-19 19:10:54 UTC) #4

Brian Wilkerson

5 years, 7 months ago (2015-05-19 19:33:10 UTC) #5

Message was sent while issue was closed.

LGTM as a temporary work-around. The real solution, which we'll have to wait to
make, is to not nest FunctionDeclaration in FunctionDeclarationStatement.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages