Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 114473002: fix linter on svg (Closed)

Created:
7 years ago by Jennifer Messerly
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
XML namespaces are such fun :)
7 years ago (2013-12-12 20:17:18 UTC) #1
Siggi Cherem (dart-lang)
lgtm, thanks :) https://codereview.chromium.org/114473002/diff/1/pkg/polymer/test/build/linter_test.dart File pkg/polymer/test/build/linter_test.dart (right): https://codereview.chromium.org/114473002/diff/1/pkg/polymer/test/build/linter_test.dart#newcode509 pkg/polymer/test/build/linter_test.dart:509: }, {}); This nuance will go ...
7 years ago (2013-12-12 20:23:19 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/114473002/diff/1/pkg/polymer/test/build/linter_test.dart File pkg/polymer/test/build/linter_test.dart (right): https://codereview.chromium.org/114473002/diff/1/pkg/polymer/test/build/linter_test.dart#newcode509 pkg/polymer/test/build/linter_test.dart:509: }, {}); On 2013/12/12 20:23:19, Siggi Cherem (dart-lang) wrote: ...
7 years ago (2013-12-12 20:42:01 UTC) #3
Jennifer Messerly
7 years ago (2013-12-12 20:42:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698