Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 11447018: Ignore not all, but only some problems in dart:core (Closed)

Created:
8 years ago by scheglov
Modified:
8 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/DartCompilerMainContext.java View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
8 years ago (2012-12-05 22:24:23 UTC) #1
Brian Wilkerson
LGTM, but I would like to understand better the reason why these errors were chosen ...
8 years ago (2012-12-05 22:27:58 UTC) #2
scheglov
On 2012/12/05 22:27:58, Brian Wilkerson wrote: > LGTM, but I would like to understand better ...
8 years ago (2012-12-05 22:39:20 UTC) #3
Brian Wilkerson
8 years ago (2012-12-05 22:59:47 UTC) #4
> Basically these are the ones which may be false-positive.
> This is continuation of http://code.google.com/p/dart/issues/detail?id=7128

Thanks! I understand now. Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698