- Add an extension test which throws from native code.

- Add an extension test which throws from native code.
Committed: https://code.google.com/p/dart/source/detail?r=15728

[Bill Hesse, 2012-12-05 12:26:07]

LGTM.

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc
File runtime/bin/test_extension.cc (right):

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc...
runtime/bin/test_extension.cc:34: 
two lines between functions

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc...
runtime/bin/test_extension.cc:47: if ((strcmp("TestExtension_ThrowMeTheBall",
cname) == 0) && argc == 1) {
We use !strcmp above.  Make the two consistent, either way.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_fail_test.dart (right):

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_test.dart:58: print("ERR:
${result.stderr}\n\n");
We usually remove all printing code from tests, since it is easy to add back in
when debugging.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_fail_tester.dart (right):

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_tester.dart:11: Expect.equals('cat 13',
new Cat(13).toString(), 'new Cat(13).toString()');
Perhaps remove these, since they are in the other test.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_tester.dart:17: 
Write comment: This tests throwing an exception from native code that is called
from an event in the event loop.

[Ivan Posva, 2012-12-05 13:01:29]

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc
File runtime/bin/test_extension.cc (right):

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc...
runtime/bin/test_extension.cc:34: 
On 2012/12/05 12:26:07, Bill Hesse wrote:
> two lines between functions

Done.

https://codereview.chromium.org/11447010/diff/1/runtime/bin/test_extension.cc...
runtime/bin/test_extension.cc:47: if ((strcmp("TestExtension_ThrowMeTheBall",
cname) == 0) && argc == 1) {
On 2012/12/05 12:26:07, Bill Hesse wrote:
> We use !strcmp above.  Make the two consistent, either way.

strcmp does not return a bool. Changed the code above.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_fail_test.dart (right):

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_test.dart:58: print("ERR:
${result.stderr}\n\n");
On 2012/12/05 12:26:07, Bill Hesse wrote:
> We usually remove all printing code from tests, since it is easy to add back
in
> when debugging.

The problem is that when it fails on the buildbot it is too late to add the
printing back in.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_fail_tester.dart (right):

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_tester.dart:11: Expect.equals('cat 13',
new Cat(13).toString(), 'new Cat(13).toString()');
On 2012/12/05 12:26:07, Bill Hesse wrote:
> Perhaps remove these, since they are in the other test.

Done.

https://codereview.chromium.org/11447010/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_fail_tester.dart:17: 
On 2012/12/05 12:26:07, Bill Hesse wrote:
> Write comment: This tests throwing an exception from native code that is
called
> from an event in the event loop.

Done.