Revert "By default use current code page on Windows for decoding string"

Revert "By default use current code page on Windows for decoding string"

This reverts commit c247cd299958d0ee713dcfef8aaf44d230a3a7e0.

Revert "Fix memory leaks in system string patch"

This reverts commit 5e533a0c383518fc1851fbdc01a796f7d6b077f8.

Committed: https://code.google.com/p/dart/source/detail?r=15854

[Bob Nystrom, 2012-12-07 18:47:53]

TBR.

[Emily Fortuna, 2012-12-07 18:52:54]

lgtm to revert

[Mads Ager (google), 2012-12-07 19:34:43]

LGTM.

This will definitely break Pub in Russia. :(

We need to reapply this change as it does the right thing for windows processes.
However, if we are using processes that writes UTF8 output we need to put
process options into the process starting for those to read the output as UTF8
in Process.run. ProcessOptions has a stdoutEncoding and stderrEncoding that with
this change became SYSTEM (which on windows is current code page). Bob, can you
look into the commands that you use. We really, really need to use this patch
and SYSTEM for at least mklink. But maybe we need to specify UTF8 for others.

[Mads Ager (google), 2012-12-07 19:35:59]

On 2012/12/07 19:34:43, Mads Ager wrote:
> LGTM.
> 
> This will definitely break Pub in Russia. :(
> 
> We need to reapply this change as it does the right thing for windows
processes.
> However, if we are using processes that writes UTF8 output we need to put
> process options into the process starting for those to read the output as UTF8
> in Process.run. ProcessOptions has a stdoutEncoding and stderrEncoding that
with
> this change became SYSTEM (which on windows is current code page). Bob, can
you
> look into the commands that you use. We really, really need to use this patch
> and SYSTEM for at least mklink. But maybe we need to specify UTF8 for others.

Another way to achieve this is to go back to using UTF8 by default and then make
sure to specify SYSTEM for the commands that uses code page output on Windows
(such as mklink and other builtin commands).

[Mads Ager (google), 2012-12-07 20:02:13]

On 2012/12/07 19:35:59, Mads Ager wrote:
> On 2012/12/07 19:34:43, Mads Ager wrote:
> > LGTM.
> > 
> > This will definitely break Pub in Russia. :(
> > 
> > We need to reapply this change as it does the right thing for windows
> processes.
> > However, if we are using processes that writes UTF8 output we need to put
> > process options into the process starting for those to read the output as
UTF8
> > in Process.run. ProcessOptions has a stdoutEncoding and stderrEncoding that
> with
> > this change became SYSTEM (which on windows is current code page). Bob, can
> you
> > look into the commands that you use. We really, really need to use this
patch
> > and SYSTEM for at least mklink. But maybe we need to specify UTF8 for
others.
> 
> Another way to achieve this is to go back to using UTF8 by default and then
make
> sure to specify SYSTEM for the commands that uses code page output on Windows
> (such as mklink and other builtin commands).

And the right way to fix it would be to null terminate the strings that I use.
;-) I'll get this relanded ASAP to fix the Russia situation.