Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 11446040: Remove stale dependencies on dart2js scripts. (Closed)

Created:
8 years ago by ahe
Modified:
8 years ago
Reviewers:
kasperl, kustermann
CC:
reviews_dartlang.org, ricow1, dgrove
Visibility:
Public.

Description

Remove stale dependencies on dart2js scripts. Also, add build rule to delete old dart2js scripts. Committed: https://code.google.com/p/dart/source/detail?r=15841

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M dart/dart.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M dart/utils/apidoc/apidoc.gyp View 1 chunk +5 lines, -2 lines 0 comments Download
M dart/utils/compiler/compiler.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
A dart/utils/compiler/remove_old_scripts.py View 1 chunk +28 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
ahe
8 years ago (2012-12-06 13:35:31 UTC) #1
kustermann
8 years ago (2012-12-06 15:51:39 UTC) #2
LGTM

https://codereview.chromium.org/11446040/diff/1/dart/utils/compiler/remove_ol...
File dart/utils/compiler/remove_old_scripts.py (right):

https://codereview.chromium.org/11446040/diff/1/dart/utils/compiler/remove_ol...
dart/utils/compiler/remove_old_scripts.py:11: python tools/list_files.py
FILE_TO_TOUCH FILES_TO_DELETE...
You should change that to "remove_old_scripts.py".

Powered by Google App Engine
This is Rietveld 408576698