Issue 11446020: Set BP in closurized function if necessary

Issue 11446020: Set BP in closurized function if necessary (Closed)

Created:
8 years ago by hausner

Modified:
8 years ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Set BP in closurized function if necessary If a function has been closurized, and both the regular function as well as the closurized function are already compiled when the user sets a breakpoint, then two code breakpoints have to be installed. Fixed issue 2318. Committed: https://code.google.com/p/dart/source/detail?r=15764

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -13 lines)			Patch
	M	runtime/vm/debugger.cc	View	1 2 3	2 chunks	+28 lines, -13 lines	0 comments	Download
	M	runtime/vm/object.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one suggestion. https://codereview.chromium.org/11446020/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/11446020/diff/1/runtime/vm/debugger.cc#newcode1004 runtime/vm/debugger.cc:1004: if (target_function.implicit_closure_function() != Function::null()) { ...

8 years ago (2012-12-05 22:54:34 UTC) #2

hausner

8 years ago (2012-12-05 23:04:13 UTC) #3

Thank you!

https://codereview.chromium.org/11446020/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/11446020/diff/1/runtime/vm/debugger.cc#newcod...
runtime/vm/debugger.cc:1004: if (target_function.implicit_closure_function() !=
Function::null()) {
On 2012/12/05 22:54:34, regis wrote:
> You use implicit_closure_function() and ImplicitClosureFunction(), which also
> creates one. How about renaming the new implicit_closure_function() to
> HasImplicitClosureFunction() and making it return a boolean?

Done.

https://codereview.chromium.org/11446020/diff/1/runtime/vm/debugger.cc#newcod...
runtime/vm/debugger.cc:1005: // There is a closureized version of this function.
If the closure
On 2012/12/05 22:54:34, regis wrote:
> closurized

Done.

https://codereview.chromium.org/11446020/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/11446020/diff/1/runtime/vm/object.h#newcode1150
runtime/vm/object.h:1150: RawFunction* implicit_closure_function() const;
On 2012/12/05 22:54:34, regis wrote:
> See my comment in the cc file.

Done.

Expand Messages | Collapse Messages