Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 11446016: Fix build step on android bot (Closed)

Created:
8 years ago by vsm
Modified:
8 years ago
Reviewers:
Emily Fortuna, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix build step on android bot It had been failing because os was "android dart" instead of "android". Committed: https://code.google.com/p/dart/source/detail?r=15745

Patch Set 1 #

Patch Set 2 : Fix target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/bots/android.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years ago (2012-12-05 19:33:03 UTC) #1
Emily Fortuna
lgtm
8 years ago (2012-12-05 19:34:27 UTC) #2
gram
8 years ago (2012-12-05 19:38:18 UTC) #3
Message was sent while issue was closed.
Ah, I wondered why we used to see that! Thanks for fixing. Is the 'dart' target
one you added? Should we be using 'samples'?

lgtm

Powered by Google App Engine
This is Rietveld 408576698