Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1144563003: Modify WorkOrder to use a dependency walking algorithm that handles cycles. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Modify WorkOrder to use a dependency walking algorithm that handles cycles. There is no functional change in the behavior of the WorkOrder class; if a cycle is found, we still set the ".exception" field in all the work items involved in the cycle. In a follow-up CL I will add the ability to override this behavior when computing constant values. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -74 lines) Patch
M pkg/analyzer/lib/src/task/driver.dart View 5 chunks +236 lines, -67 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 6 chunks +82 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 7 months ago (2015-05-14 20:36:50 UTC) #1
Paul Berry
5 years, 7 months ago (2015-05-14 20:37:06 UTC) #3
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-14 20:52:04 UTC) #4
Paul Berry
5 years, 7 months ago (2015-05-14 22:38:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698