Issue 11444015: Create mock pub links in the build for all packages under pkg, not a hard-coded list

Issue 11444015: Create mock pub links in the build for all packages under pkg, not a hard-coded list (Closed)

Created:
8 years ago by Alan Knight

Modified:
8 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Bob Nystrom, nweiz

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Create mock pub links for all packages under pkg, not a hard-coded list Committed: https://code.google.com/p/dart/source/detail?r=15811

Patch Set 1 #

Total comments: 7

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	pkg/pkg.gyp	View		1 chunk	+1 line, -10 lines	0 comments	Download
	A	tools/list_pkg_directories.py	View		1 chunk	+18 lines, -0 lines	7 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py File tools/list_pkg_directories.py (right): https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py#newcode1 tools/list_pkg_directories.py:1: #!/usr/bin/env python The style guide we use for ...

8 years ago (2012-12-06 13:44:39 UTC) #2

Alan Knight

https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py File tools/list_pkg_directories.py (right): https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py#newcode1 tools/list_pkg_directories.py:1: #!/usr/bin/env python On 2012/12/06 13:44:39, ahe wrote: > The ...

8 years ago (2012-12-06 22:09:23 UTC) #3

ahe

8 years ago (2012-12-06 23:02:28 UTC) #4

Message was sent while issue was closed.

Did you verify that this prints anything?  I don't see any calls to print, so I
assumed you knew some python magic, but now you're making me think you're aren't
a python wizard after all ;-)

https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py
File tools/list_pkg_directories.py (right):

https://codereview.chromium.org/11444015/diff/1/tools/list_pkg_directories.py...
tools/list_pkg_directories.py:1: #!/usr/bin/env python
On 2012/12/06 22:09:23, Alan Knight wrote:
> On 2012/12/06 13:44:39, ahe wrote:
> > The style guide we use for Python is
> > http://www.chromium.org/developers/coding-style.
> > 
> > As far as I can tell, this style guide does not require you to wrap scripts
> like
> > this in:
> > 
> > if __name__ == '__main__':
> >   sys.exit(main())
> > 
> > So I guess this is fine.
> 
> OK. I don't really know Python, so I don't even know what that would do.

See:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Main#Main

Expand Messages | Collapse Messages