Issue 1144393006: Bug fixes for the new task model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1144393006: Bug fixes for the new task model (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson

Modified:
5 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Bug fixes for the new task model R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/40e925078f9caa0d03c4b9c13f9554906d6eaa9a

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -5 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	3 chunks	+18 lines, -3 lines	1 comment	Download
M	pkg/analysis_server/test/services/completion/optype_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/move_file_test.dart	View	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/1144393006/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1144393006/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode36 pkg/analysis_server/lib/src/analysis_server.dart:36: import 'package:analyzer/src/context/cache.dart'; Sort imports?

5 years, 6 months ago (2015-06-01 22:19:06 UTC) #3

Brian Wilkerson

5 years, 6 months ago (2015-06-01 23:42:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
40e925078f9caa0d03c4b9c13f9554906d6eaa9a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages