Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 11442068: A few small changes to the "pub lish" confirmation UI. (Closed)

Created:
8 years ago by nweiz
Modified:
8 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A few small changes to the "pub lish" confirmation UI. * Don't collapse the root directory of a directory tree, since this is usually going to be a very heterogeneous set of files and directories. * Indent "(N more...)" two fewer spaces. This makes it clearer at what level things are collapsed when it comes immediately after a directory. E.g. |-- dir | '-- file | (6 more...) |-- other-dir vs |-- dir | '-- file | (6 more...) |-- other-dir Committed: https://code.google.com/p/dart/source/detail?r=16085

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M utils/pub/directory_tree.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/directory_tree_test.dart View 1 3 chunks +53 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
8 years ago (2012-12-12 23:32:17 UTC) #1
Bob Nystrom
I don't see a difference in your example. I think the current appearance should be ...
8 years ago (2012-12-13 00:57:32 UTC) #2
Bob Nystrom
8 years ago (2012-12-13 01:07:01 UTC) #3
Update the tests and then LGTM!

https://codereview.chromium.org/11442068/diff/1/utils/pub/directory_tree.dart
File utils/pub/directory_tree.dart (right):

https://codereview.chromium.org/11442068/diff/1/utils/pub/directory_tree.dart...
utils/pub/directory_tree.dart:112: if (name == null || childNames.length <= 10)
{
The intent here is to never elide at the top level?

If so, we should add a test for this too.

https://codereview.chromium.org/11442068/diff/1/utils/pub/directory_tree.dart...
utils/pub/directory_tree.dart:126: buffer.add('| (${childNames.length - 6}
more...)\n');
You'll need to update the test too.

Powered by Google App Engine
This is Rietveld 408576698