Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 11442053: Extend sminess propagator to process branch instructions. (Closed)

Created:
8 years ago by Florian Schneider
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extend sminess propagator to process branch instructions. When doing comparisons like (x == null) and the comparison is dominated by a smi-check, we can fold the comparison away. One example where this occurs is the List constructor where the length parameter is checked for null. If not null, the length of the list is fixed and known and can be used to eliminate bounds checks. Committed: https://code.google.com/p/dart/source/detail?r=16037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years ago (2012-12-12 13:38:24 UTC) #1
Vyacheslav Egorov (Google)
8 years ago (2012-12-12 13:39:21 UTC) #2
lgtm

but we should really work towards a unified type propagation.

Powered by Google App Engine
This is Rietveld 408576698