Issue 11442009: Make RuntimeError an Error

Issue 11442009: Make RuntimeError an Error (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
karlklose, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make RuntimeError an Error Committed: https://code.google.com/p/dart/source/detail?r=15981

Patch Set 3 : Updated cf. comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
M	sdk/lib/core/errors.dart	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/core/exceptions.dart	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/11442009/diff/1/sdk/lib/core/errors.dart File sdk/lib/core/errors.dart (right): https://codereview.chromium.org/11442009/diff/1/sdk/lib/core/errors.dart#newcode252 sdk/lib/core/errors.dart:252: class RuntimeError implements Error { If the VM doesn't ...

8 years ago (2012-12-06 19:40:54 UTC) #2

karlklose

LGTM. It is maybe a good idea to have it in js_helper until we have ...

8 years ago (2012-12-07 09:27:38 UTC) #3

Johnni Winther

8 years ago (2012-12-11 15:30:24 UTC) #4

https://codereview.chromium.org/11442009/diff/1/sdk/lib/core/errors.dart
File sdk/lib/core/errors.dart (right):

https://codereview.chromium.org/11442009/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:250: * Exception thrown when a runtime error occurs.
On 2012/12/07 09:27:38, karlklose wrote:
> Exception -> Error.

Done.

https://codereview.chromium.org/11442009/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:252: class RuntimeError implements Error {
On 2012/12/06 19:40:54, Lasse Reichstein Nielsen wrote:
> If the VM doesn't use this class, and I don't think it does since it's not
> mentioned in exceptions.h, this could just as well be in js_helper.dart.
> (Alternatively coordinate with the VM about how to handle runtime errors).

Some language tests rely on it so it cannot be moved to js_helper immediately.

Expand Messages | Collapse Messages