Pass handles not raw objects into methods.

Pass handles not raw objects into methods.
Committed: https://code.google.com/p/dart/source/detail?r=15748

[siva, 2012-12-05 19:18:47]

lgtm

https://codereview.chromium.org/11441021/diff/1/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11441021/diff/1/runtime/vm/dart_entry.cc#newc...
runtime/vm/dart_entry.cc:141: kNameOffset);
const String& result = String::CheckedHandle(array_At(...));
return result.raw();

maybe ?

[srdjan, 2012-12-05 19:30:07]

https://codereview.chromium.org/11441021/diff/1/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11441021/diff/1/runtime/vm/dart_entry.cc#newc...
runtime/vm/dart_entry.cc:141: kNameOffset);
On 2012/12/05 19:18:48, siva wrote:
> const String& result = String::CheckedHandle(array_At(...));
> return result.raw();
> 
> maybe ?

Discussed, ignoring.

[Florian Schneider, 2012-12-06 09:48:16]

dbc:

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/dart_entry.cc#n...
runtime/vm/dart_entry.cc:138: String& result = String::Handle();
Allocating a handle just for casting seems an expensive way to cast to String.
Why not not return RawObject* as before? The caller will almost always allocate
a handle itself and can do the cast as well.

[Kevin Millikin (Google), 2012-12-06 10:36:28]

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/code_generator....
runtime/vm/code_generator.cc:843: ArgumentsDescriptor
arg_descriptor(arg_desc_array);
I was trying to avoid this API, which I still think is unnecessary.

Since we have to have it, we should pass the Array handle in to
ResolveCompileInstanceCallTarget, and construct the ArgumentsDescriptor there,
rather than requiring all callers to create one.

[Kevin Millikin (Google), 2012-12-06 10:44:02]

DBC.

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11441021/diff/2002/runtime/vm/dart_entry.cc#n...
runtime/vm/dart_entry.cc:138: String& result = String::Handle();
On 2012/12/06 09:48:16, Florian Schneider wrote:
> Allocating a handle just for casting seems an expensive way to cast to String.
> Why not not return RawObject* as before? The caller will almost always
allocate
> a handle itself and can do the cast as well.

The only caller just does pointer equality to RawString*, which works if this is
RawObject*.  In fact, this method can be replaced by:

bool ArgumentsDescriptor::MatchNameAt(intptr_t index,
                                      const String& other) const {
  return (array_.At(...) == other.raw());
}