Issue 1144023009: Adapt the existing incremental resolution implementation to the new model.

Issue 1144023009: Adapt the existing incremental resolution implementation to the new model. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Adapt the existing incremental resolution implementation to the new model. This is hopefully a temporary implementation, to be used until we have a proper task-based version. Otherwise the new task model is too slow to conveniently dogfood it. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4ca0c7acbbc30c7739eaa5b314bb83a76da51fbe

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes for review comments. #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+298 lines, -103 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View		6 chunks	+23 lines, -12 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	1	5 chunks	+85 lines, -58 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View		4 chunks	+10 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1	13 chunks	+142 lines, -26 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/context/cache_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1144023009/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1144023009/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode1763 pkg/analyzer/lib/src/context/context.dart:1763: // TODO(brianwilkerson) Implement this. Implement what? https://codereview.chromium.org/1144023009/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File ...

5 years, 7 months ago (2015-05-23 15:58:45 UTC) #2

scheglov

5 years, 7 months ago (2015-05-23 23:56:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4ca0c7acbbc30c7739eaa5b314bb83a76da51fbe (presubmit successful).

Expand Messages | Collapse Messages