Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11440010: Move runtime/tools/make_version.py to tools/ and use GetVersion from utils.py (Closed)

Created:
8 years ago by kustermann
Modified:
8 years ago
Reviewers:
ricow1, ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move runtime/tools/make_version.py to tools/ and use GetVersion from utils.py Currently runtime/tools/make_version.py creates the version string itself. Since this is already done in tools/release/version.dart, we should use that. tools/utils.py provides a python wrapper around it with GetVersion(). Committed: https://code.google.com/p/dart/source/detail?r=15769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -123 lines) Patch
M runtime/dart-runtime.gyp View 2 chunks +5 lines, -3 lines 0 comments Download
D runtime/tools/make_version.py View 1 chunk +0 lines, -119 lines 0 comments Download
A tools/make_version.py View 1 chunk +69 lines, -0 lines 0 comments Download
M tools/release/version.dart View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kustermann
8 years ago (2012-12-05 11:41:36 UTC) #1
Ivan Posva
8 years ago (2012-12-05 12:46:42 UTC) #2 
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698