Issue 11439029: Fix SecureSocket bug where socket was not closed after all data was flushed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11439029: Fix SecureSocket bug where socket was not closed after all data was flushed. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix SecureSocket bug where socket was not closed after all data was flushed. BUG=dart:6730 Committed: https://code.google.com/p/dart/source/detail?r=15779

Patch Set 1 #

Patch Set 2 : Make sure close() can be called multiple times. #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
	M	sdk/lib/io/secure_socket.dart	View	1	6 chunks	+17 lines, -17 lines	0 comments	Download
	M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years ago (2012-12-06 10:35:31 UTC) #2

LGTM

https://codereview.chromium.org/11439029/diff/2001/tests/standalone/standalon...
File tests/standalone/standalone.status (left):

https://codereview.chromium.org/11439029/diff/2001/tests/standalone/standalon...
tests/standalone/standalone.status:9: io/secure_socket_test: Pass, Timeout #
Issue 6730.
Do these tests expose all of the cases that you have fixed? If not, please
attempt to create more tests that hit the individual issues.

Expand Messages | Collapse Messages