Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11438044: Remove some warnings and errors from dart2js. (Closed)

Created:
8 years ago by karlklose
Modified:
8 years ago
Reviewers:
floitsch, ngeoffray, sra1
CC:
reviews_dartlang.org, sra1, ngeoffray
Visibility:
Public.

Description

Remove some warnings and errors from dart2js. Committed: https://code.google.com/p/dart/source/detail?r=15955

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
karlklose
https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/native_handler.dart File sdk/lib/_internal/compiler/implementation/native_handler.dart (left): https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/native_handler.dart#oldcode804 sdk/lib/_internal/compiler/implementation/native_handler.dart:804: && nativeEmitter.toNativeName(element.getEnclosingClass()) == 'DOMType') { @sra: Is this dead ...
8 years ago (2012-12-06 11:39:23 UTC) #1
floitsch
LGTM. please try to make sure Stephen and Nicolas saw the comments that were for ...
8 years ago (2012-12-06 12:32:25 UTC) #2
ngeoffray
LGTM https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right): https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart#newcode210 sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:210: if (node is !HInvokeDynamicMethod) return null; On 2012/12/06 ...
8 years ago (2012-12-06 23:05:05 UTC) #3
sra1
https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/native_handler.dart File sdk/lib/_internal/compiler/implementation/native_handler.dart (left): https://codereview.chromium.org/11438044/diff/1/sdk/lib/_internal/compiler/implementation/native_handler.dart#oldcode804 sdk/lib/_internal/compiler/implementation/native_handler.dart:804: && nativeEmitter.toNativeName(element.getEnclosingClass()) == 'DOMType') { On 2012/12/06 11:39:23, karlklose ...
8 years ago (2012-12-10 22:46:11 UTC) #4
karlklose
8 years ago (2012-12-11 09:07:50 UTC) #5 
Thanks for the review.

@Stephen: I removed the dead code in this CL.

Powered by Google App Engine
This is Rietveld 408576698