Issue 11438017: Pass IC data and arguments descriptor to IC miss runtime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11438017: Pass IC data and arguments descriptor to IC miss runtime functions. (Closed)

Created:
8 years ago by Kevin Millikin (Google)

Modified:
8 years ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pass IC data and arguments descriptor to IC miss runtime functions. Before, we obtained them by pattern matching backwards on the machine instructions at the call site. This previous approach becomes unwieldy when we need to use to use multiple instance call patterns. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15737

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -155 lines)			Patch
M	runtime/vm/code_generator.h	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	7 chunks	+40 lines, -27 lines	0 comments	Download
M	runtime/vm/code_patcher.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	3 chunks	+11 lines, -41 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	3 chunks	+12 lines, -41 lines	0 comments	Download
M	runtime/vm/code_patcher_x64_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	2 chunks	+15 lines, -14 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	3 chunks	+15 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	3 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages