Issue 1143573003: Add dart:io and dart:_builtin to the dartium snapshot so that vmservices can work, the previous app…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143573003: Add dart:io and dart:_builtin to the dartium snapshot so that vmservices can work, the previous app… (Closed)

Created:
5 years, 7 months ago by siva

Modified:
5 years, 7 months ago

Reviewers:
Cutch, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Add dart:io and dart:_builtin to the dartium snapshot so that vmservices can work, the previous approach of trying to load dart:io and dart:_builtin from the sources does not work in a dart-sdk distribution as the sources are not copied out. R=johnmccutchan@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=45830

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
M	runtime/bin/bin.gypi	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/bin/vmservice_dartium.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
A	runtime/bin/vmserviceio_dartium.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

siva

5 years, 7 months ago (2015-05-15 23:15:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45830 (presubmit successful).