Issue 11434106: Part of fix for http://dartbug.com/6528

Issue 11434106: Part of fix for http://dartbug.com/6528 (Closed)

Created:
8 years ago by kustermann

Modified:
8 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Part of fix for http://dartbug.com/6528 Committed: https://code.google.com/p/dart/source/detail?r=15690

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	runtime/dart-runtime.gyp	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
	M	runtime/vm/libdart_dependency_helper.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11434106/diff/1/runtime/dart-runtime.gyp File runtime/dart-runtime.gyp (right): https://codereview.chromium.org/11434106/diff/1/runtime/dart-runtime.gyp#newcode63 runtime/dart-runtime.gyp:63: # We need to list the libdart_dependency_helper executable ...

8 years ago (2012-12-04 15:33:58 UTC) #2

kustermann

8 years ago (2012-12-05 09:08:53 UTC) #3

https://codereview.chromium.org/11434106/diff/1/runtime/dart-runtime.gyp
File runtime/dart-runtime.gyp (right):

https://codereview.chromium.org/11434106/diff/1/runtime/dart-runtime.gyp#newc...
runtime/dart-runtime.gyp:63: # We need to list the libdart_dependency_helper
executable here otherwise
On 2012/12/04 15:33:58, ahe wrote:
> Long line.

Done.

https://codereview.chromium.org/11434106/diff/1/runtime/dart-runtime.gyp#newc...
runtime/dart-runtime.gyp:64: # the action doesn't get executed if any of
libdart/libdart_withcore
On 2012/12/04 15:33:58, ahe wrote:
> It is not only libdart/libdart_withcore.
> 
> Also, the sentence is a bit convoluted, you could try something like this:
> 
> "Depend on libdart_dependency_helper to track the libraries it depends on".

Done.

https://codereview.chromium.org/11434106/diff/1/runtime/vm/libdart_dependency...
File runtime/vm/libdart_dependency_helper.cc (right):

https://codereview.chromium.org/11434106/diff/1/runtime/vm/libdart_dependency...
runtime/vm/libdart_dependency_helper.cc:5: #include <stdio.h>
On 2012/12/04 15:33:58, ahe wrote:
> Why do you need that?
We don't need it, you're right.

Expand Messages | Collapse Messages