Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11434079: Adding dart:indexed_db. (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
ahe, sra1
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Adding dart:indexed_db. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15719

Patch Set 1 #

Patch Set 2 : Tweaks. #

Total comments: 4

Patch Set 3 : Syncing to latest. #

Patch Set 4 : Fixing errant merge issue. #

Patch Set 5 : Syncing with latest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2299 lines, -2230 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 10 chunks +10 lines, -1026 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +3 lines, -986 lines 0 comments Download
M sdk/lib/html/scripts/dartdomgenerator.py View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/html/scripts/generator.py View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/html/scripts/htmleventgenerator.py View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/html/scripts/htmlrenamer.py View 1 2 3 4 5 chunks +13 lines, -3 lines 0 comments Download
M sdk/lib/html/scripts/systemhtml.py View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/html/src/dart2js_Conversions.dart View 1 chunk +0 lines, -54 lines 0 comments Download
M sdk/lib/html/src/dart2js_IDBKeyRangeFactoryProvider.dart View 1 1 chunk +0 lines, -51 lines 0 comments Download
M sdk/lib/html/src/dartium_FactoryProviders.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 2 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate View 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate View 1 chunk +5 lines, -3 lines 0 comments Download
A sdk/lib/html/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 1 chunk +111 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/html/templates/html/dartium/indexed_db_dartium.darttemplate View 1 1 chunk +33 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate View 1 chunk +9 lines, -9 lines 0 comments Download
A sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 1 chunk +1022 lines, -0 lines 0 comments Download
A sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 1 chunk +991 lines, -0 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 9 chunks +16 lines, -15 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/html/indexeddb_3_test.dart View 6 chunks +11 lines, -10 lines 0 comments Download
M tests/html/indexeddb_4_test.dart View 5 chunks +28 lines, -27 lines 0 comments Download
M tools/create_sdk.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
lgtm https://chromiumcodereview.appspot.com/11434079/diff/2001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right): https://chromiumcodereview.appspot.com/11434079/diff/2001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#newcode123 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:123: class Any native "*IDBAny" { We should get ...
8 years ago (2012-12-03 21:15:30 UTC) #1
blois
https://codereview.chromium.org/11434079/diff/2001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right): https://codereview.chromium.org/11434079/diff/2001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#newcode123 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:123: class Any native "*IDBAny" { On 2012/12/03 21:15:30, sra1 ...
8 years ago (2012-12-03 21:21:52 UTC) #2
blois
+ahe to let Aarhus compiler folks know. FYI- this is the last lib split out ...
8 years ago (2012-12-04 21:36:38 UTC) #3
ahe
8 years ago (2012-12-04 21:53:55 UTC) #4 
Changes to sdk/lib/_internal/compiler/implementation/, LGTM

Powered by Google App Engine
This is Rietveld 408576698