Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 11434034: Improve error handling in HttpClient (Closed)

Created:
8 years ago by Søren Gjesse
Modified:
8 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Improve error handling in HttpClient Make sure that after an error callback have been made on a HttpClientConnection no more callbacks will happen. To ensure that the HTTP parser is canceled to avoid that it continues to process whatever data was in its internal buffer. Only ever call one error callback. If the client response input stream as a n error callback use that otherwise use the one on the HttpClientConnection object. R=ager@google.com BUG=dart:7013, dart:7014 Committed: https://code.google.com/p/dart/source/detail?r=15570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M sdk/lib/io/http_impl.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 8 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years ago (2012-11-29 16:52:56 UTC) #1
Mads Ager (google)
8 years ago (2012-11-30 07:22:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698