Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1143373005: Fix TraversalSendMixin.visitDynamicPropertySet. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-22 07:38:50 UTC) #2
Anders Johnsen
LGTM
5 years, 7 months ago (2015-05-22 07:39:52 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-22 07:40:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dee663e58274e9fc055c89f09ec61560499b5eda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698