Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1143243002: dart2js: Add comment in buildTypeArgumentRepresentations. (Closed)

Created:
5 years, 7 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Add comment in buildTypeArgumentRepresentations. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/cefd7f7d524393cc8f7c4790ab577f42639b311c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
5 years, 7 months ago (2015-05-20 14:33:47 UTC) #1
floitsch
LGTM.
5 years, 7 months ago (2015-05-20 14:48:12 UTC) #2
herhut
5 years, 6 months ago (2015-06-08 09:31:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cefd7f7d524393cc8f7c4790ab577f42639b311c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698