Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142873006: Fix bug when using super and prefixes as a parenthesis expression (Closed)

Created:
5 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 7 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js_extra/23486_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js_extra/23486_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
5 years, 7 months ago (2015-05-19 18:01:19 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1142873006/diff/40001/tests/compiler/dart2js_extra/23486_helper.dart File tests/compiler/dart2js_extra/23486_helper.dart (right): https://codereview.chromium.org/1142873006/diff/40001/tests/compiler/dart2js_extra/23486_helper.dart#newcode1 tests/compiler/dart2js_extra/23486_helper.dart:1: int x = 1; Add copyright.
5 years, 7 months ago (2015-05-21 10:34:48 UTC) #5
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1142873006/diff/40001/tests/compiler/dart2js_extra/23486_helper.dart File tests/compiler/dart2js_extra/23486_helper.dart (right): https://codereview.chromium.org/1142873006/diff/40001/tests/compiler/dart2js_extra/23486_helper.dart#newcode1 tests/compiler/dart2js_extra/23486_helper.dart:1: int x = 1; On 2015/05/21 10:34:48, Johnni Winther ...
5 years, 7 months ago (2015-05-21 16:27:00 UTC) #6
Siggi Cherem (dart-lang)
5 years, 7 months ago (2015-05-21 16:35:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) manually as
23e113227caa2afc2d5f6d88688d1e792fd522fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698