Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1142853002: Handle type parameters correctly when generating hints (issue 23243) (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle type parameters correctly when generating hints (issue 23243) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1a3e349409ca84d882e1628d8a28049c88a2d65e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 3 chunks +18 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-18 16:37:11 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-18 16:39:05 UTC) #3
Brian Wilkerson
5 years, 7 months ago (2015-05-18 17:41:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a3e349409ca84d882e1628d8a28049c88a2d65e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698