Issue 11428084: Don't run pub and pkg as default, explicitly add these to the test command for running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428084: Don't run pub and pkg as default, explicitly add these to the test command for running (Closed)

Created:
8 years ago by ricow1

Modified:
8 years ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't run pub and pkg as default, explicitly add these to the test command for running Committed: https://code.google.com/p/dart/source/detail?r=15520

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testing/dart/test_options.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/11428084/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (left): https://codereview.chromium.org/11428084/diff/1/tools/testing/dart/test_options.dart#oldcode15 tools/testing/dart/test_options.dart:15: 'utils', 'pub', 'lib', 'pkg']; I think we need to ...

8 years ago (2012-11-29 14:51:01 UTC) #2

ricow1

8 years ago (2012-11-29 14:53:32 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages

Issue 11428084: Don't run pub and pkg as default, explicitly add these to the test command for running (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages