Issue 11428079: Cleanup: Remove unused return value in OptimizeTypeArguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428079: Cleanup: Remove unused return value in OptimizeTypeArguments. (Closed)

Created:
8 years ago by Florian Schneider

Modified:
8 years ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove unused return value in OptimizeTypeArguments. Instead use it to replace the bool* output-parameter. Committed: https://code.google.com/p/dart/source/detail?r=15515

Patch Set 1 #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -27 lines)			Patch
	M	runtime/vm/code_generator.cc	View		3 chunks	+10 lines, -27 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/11428079/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11428079/diff/1/runtime/vm/code_generator.cc#newcode410 runtime/vm/code_generator.cc:410: return replaced; return false; https://codereview.chromium.org/11428079/diff/1/runtime/vm/code_generator.cc#newcode415 runtime/vm/code_generator.cc:415: return replaced; ...

8 years ago (2012-11-29 12:57:05 UTC) #2

srdjan

8 years ago (2012-11-29 21:12:20 UTC) #3

Message was sent while issue was closed.

dbc

https://codereview.chromium.org/11428079/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11428079/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:438: }
Add } else { return false; } here and remove variable 'replaced' ?

Expand Messages | Collapse Messages