Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11428033: Window.close documentation. (Closed)

Created:
8 years ago by Andrei Mouravski
Modified:
8 years ago
Reviewers:
Kathy Walrath, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Window.close documentation. Committed: https://code.google.com/p/dart/source/detail?r=15419

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 chunks +29 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +29 lines, -1 line 0 comments Download
M sdk/lib/html/src/CrossFrameTypes.dart View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrei Mouravski
Please let me know if this does not make sense.
8 years ago (2012-11-27 19:38:58 UTC) #1
Kathy Walrath
Good info! Just a couple of comments. -k- https://codereview.chromium.org/11428033/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11428033/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode22256 sdk/lib/html/dart2js/html_dart2js.dart:22256: * ...
8 years ago (2012-11-27 19:52:42 UTC) #2
Andrei Mouravski
PTAL. https://codereview.chromium.org/11428033/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11428033/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode22256 sdk/lib/html/dart2js/html_dart2js.dart:22256: * other.close();· On 2012/11/27 19:52:42, Kathy Walrath wrote: ...
8 years ago (2012-11-27 20:39:26 UTC) #3
Kathy Walrath
8 years ago (2012-11-27 21:57:39 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698