Issue 11428020: Temporarily reverting class field and method name minification.

Issue 11428020: Temporarily reverting class field and method name minification. (Closed)

Created:
8 years ago by erikcorry

Modified:
8 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Temporarily reverting class field and method name minification. BUG=6763 Committed: https://code.google.com/p/dart/source/detail?r=15445

Patch Set 2 : Add regression test #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -399 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/printer.dart	View		9 chunks	+13 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		2 chunks	+4 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		19 chunks	+40 lines, -83 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart	View		1 chunk	+0 lines, -108 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		15 chunks	+66 lines, -144 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/native_helper.dart	View		4 chunks	+10 lines, -30 lines	0 comments	Download
A	tests/compiler/dart2js_native/native_field_name_test.dart	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	utils/compiler/build_helper.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11428020/diff/2001/utils/compiler/build_helper.dart File utils/compiler/build_helper.dart (left): https://codereview.chromium.org/11428020/diff/2001/utils/compiler/build_helper.dart#oldcode39 utils/compiler/build_helper.dart:39: r' ${DART_VM_FLAGS:---enable_checked_mode}'); no need to revert this one. ...

8 years ago (2012-11-27 15:42:26 UTC) #1

erikcorry

8 years ago (2012-12-11 08:36:27 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/11428020/diff/2001/utils/compiler/build_helpe...
File utils/compiler/build_helper.dart (left):

https://codereview.chromium.org/11428020/diff/2001/utils/compiler/build_helpe...
utils/compiler/build_helper.dart:39: r'
${DART_VM_FLAGS:---enable_checked_mode}');
On 2012/11/27 15:42:26, floitsch wrote:
> no need to revert this one. right?

True

Expand Messages | Collapse Messages