Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1142743002: Fix create sdk after revision being returned as real integer (Closed)

Created:
5 years, 7 months ago by ricow1
Modified:
5 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix create sdk after revision being returned as real integer The revision (which is a git count + 100k) is now a real integer, before it was a string returned by parsing output from svn info TBR=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4dc8b8144507a97730b75750aa1139af45d1dba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 7 months ago (2015-05-16 16:33:17 UTC) #1
ricow1
Committed patchset #1 (id:1) manually as 4dc8b8144507a97730b75750aa1139af45d1dba0.
5 years, 7 months ago (2015-05-16 16:33:56 UTC) #2
Bill Hesse
5 years, 7 months ago (2015-05-18 15:04:52 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698