Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142423003: Add tokens for null-aware operators (Closed)

Created:
5 years, 7 months ago by hausner
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add 3 new tokens and fix all the fallout from changing token values. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bdf81243010d32f984b035567ead2d83c3def158

Patch Set 1 #

Patch Set 2 : Adding tokens for null-aware operators #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -342 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 1 chunk +13 lines, -13 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 6 chunks +272 lines, -274 lines 0 comments Download
M runtime/vm/parser_test.cc View 1 7 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/token.h View 6 chunks +42 lines, -37 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 7 months ago (2015-05-20 22:57:16 UTC) #2
rmacnak
lgtm w/ comment https://codereview.chromium.org/1142423003/diff/20001/runtime/vm/token.h File runtime/vm/token.h (right): https://codereview.chromium.org/1142423003/diff/20001/runtime/vm/token.h#newcode66 runtime/vm/token.h:66: /* Avoid trigraph ??= below. */ ...
5 years, 7 months ago (2015-05-20 23:42:43 UTC) #3
hausner
https://codereview.chromium.org/1142423003/diff/20001/runtime/vm/token.h File runtime/vm/token.h (right): https://codereview.chromium.org/1142423003/diff/20001/runtime/vm/token.h#newcode66 runtime/vm/token.h:66: /* Avoid trigraph ??= below. */ \ On 2015/05/20 ...
5 years, 7 months ago (2015-05-21 16:07:18 UTC) #4
hausner
5 years, 7 months ago (2015-05-21 16:08:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bdf81243010d32f984b035567ead2d83c3def158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698