Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1142363006: dart2js: First build all ASTs of deferred code then print them. (Closed)

Created:
5 years, 7 months ago by herhut
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: First build all ASTs of deferred code then print them. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/08e221174dd2f4469656a17b89001f6ff0bd44ab

Patch Set 1 #

Patch Set 2 : Fixed indentation #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -43 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 7 chunks +58 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
herhut
5 years, 7 months ago (2015-05-21 15:26:53 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/1142363006/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/1142363006/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1631 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1631: new Map<OutputUnit, jsAst.Expression>(); Undo change here an din ...
5 years, 7 months ago (2015-05-22 07:27:49 UTC) #2
herhut
https://codereview.chromium.org/1142363006/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/1142363006/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1631 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1631: new Map<OutputUnit, jsAst.Expression>(); On 2015/05/22 07:27:49, karlklose wrote: > ...
5 years, 7 months ago (2015-05-22 07:57:21 UTC) #3
herhut
5 years, 7 months ago (2015-05-22 07:57:22 UTC) #4
herhut
5 years, 7 months ago (2015-05-22 07:57:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
08e221174dd2f4469656a17b89001f6ff0bd44ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698