Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1142293007: Update GN build files for Mojo roll (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M runtime/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/lib/profiler_sources.gypi View 1 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 4 chunks +23 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 7 months ago (2015-05-22 18:18:55 UTC) #2
siva
lgtm
5 years, 7 months ago (2015-05-22 18:26:09 UTC) #3
Cutch
5 years, 7 months ago (2015-05-22 18:32:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d7450e43fb603b4f18e53f96b35b61da47b5bc8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698